Polish ConfigurationPropertyName.dashIgnoringElementEquals() #16671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
True - actually the default element equals has the same "problem". That was still on my list of things to do. Unfortunately, it doesn't really buy as much in terms of performance. Which is why I left it as is initially. |
philwebb
added
type: task
philwebb
pushed a commit
that referenced
this pull request
Jun 1, 2019
philwebb
added a commit
that referenced
this pull request
Jun 1, 2019
|
Thanks @izeye and @dreis2211! I've pushed this to master and also aligned |
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
wilkinsona
pushed a commit
to wilkinsona/spring-boot
that referenced
this pull request
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes
ConfigurationPropertyName.dashIgnoringElementEquals()by avoiding repeatingindexed2booleanchecks in the loop as checking it only once seems sufficient.